GH-144679: When building with VS2026 on Windows, use PlatformToolSet v145 by default #144680
Conversation
Furthermore, do not warn anymore when building with v145
PCbuild/pythoncore.vcxproj
Outdated
| </ItemGroup> | ||
| </Target> | ||
| <Target Name="_WarnAboutToolset" BeforeTargets="PrepareForBuild" Condition="$(PlatformToolset) != 'v141' and $(PlatformToolset) != 'v142' and $(PlatformToolset) != 'v143'"> | ||
| <Target Name="_WarnAboutToolset" BeforeTargets="PrepareForBuild" Condition="$(PlatformToolset) != 'v141' and $(PlatformToolset) != 'v142' and $(PlatformToolset) != 'v143' and $(PlatformToolset) != 'v145'"> |
There was a problem hiding this comment.
On main, shall we warn for older toolsets like v141 or v142 now?
Likewise, shall we keep a warning for v145 on 3.13 / 3.14?
There was a problem hiding this comment.
The minimum VS version for building Python now is 2017.
https://docs.python.org/3.15/using/configure.html
I removed the support for 2015 a year ago #124103 . However, according to the Mainstream End Date of the VS lifecycle, currently only VS2022 is still supported
https://learn.microsoft.com/lifecycle/products/visual-studio-2019
There was a problem hiding this comment.
Yeah, let's start warning for those older ones.
There was a problem hiding this comment.
The minimum VS version for building Python now is 2017.
https://docs.python.org/3.15/using/configure.html
Maybe we should change that to 2022 since we emit a warning for the older ones now?
zooba
left a comment
zooba
left a comment
There was a problem hiding this comment.
Approved with change in comments (ping me if nobody else merges)
|
I did not yet touch cpython/Tools/msi/bundle/bootstrap/pythonba.vcxproj Lines 24 to 25 in 46d5106 since this seems to be related to the deprecated msi installers. But adding |
3 participants
Furthermore do not warn when PlatformToolSet v145 is used.